-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools workaround #40
Conversation
I seem to have recent acquired the habit of reverting your changes. 😆 |
That's okay 😅 Thanks for opening the PR - I already forgot about this... By the way, today I realized that PyMC is still on an "outdated" Aesara version and the import fixes have not yet arrived for our main branch.. |
Hmm, am I missing something, or are you looking at an old commit? The upstream fix aesara-devs/aesara#1050 was merged in Aesara v2.7.8 So it seems to me like PyMC is fine, no? |
Ah... do you mean that Indeed one should probably wait until both PyMC and Aesara have new releases before merging this. |
Oh no!!! 😞 Which commands did you use to install? |
Thanks for the merge at PyMC. Does the following logic seem correct? In the screenshot above, you're running pymc 4.1.4, but since it didn't exist on conda-forge (and won't exist until the CDN updates), it couldn't have been installed from the |
Nevermind, I created several envs with Python 3.9, 3.10 and PyMC 4.1.2, 4.1.3 and 4.1.4 and none of the new environments had the issue.
After running |
😅 Great!!! |
Do not merge...
until aesara-devs/aesara#1100 and conda-forge/conda-forge-repodata-patches-feedstock#307 are also merged.