Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilevel modeling #47

Closed
OriolAbril opened this issue Mar 24, 2021 · 3 comments
Closed

Multilevel modeling #47

OriolAbril opened this issue Mar 24, 2021 · 3 comments
Assignees
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

file: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/multilevel_modeling.ipynb

This notebook endured a significant rewrite not too long ago, and is one of the go to examples on ArviZ+xarray usage. This is both its main pro and its own downfall. There are some nits to keep it up to its current golden standard.

Required changes

The notebook should be reexecuted with latest pymc3 and have the warning filter removed (there should be no warnings, if there are they should be fixed). Moreover, rerunning with latest ArviZ will generate much more aesthetically pleasing forestplots. legend=True should be used for forestplots with multiple models.

Changes for discussion

The plot forest on cell 42 should use the approach described in arviz-devs/arviz#1627 to avoid showing the 1 dots that correspond to the elements in the diagonal.

⚠️ These changes need to wait for the next ArviZ release, they require ArviZ>0.11.2, 0.11.2 is not enough.

@OriolAbril OriolAbril added the tracker id Issues used as trackers in the notebook update project, do not close! label Mar 24, 2021
@OriolAbril OriolAbril added the high impact Notebooks with most visits on docs.pymc.io label Apr 6, 2021
@farhanreynaldo
Copy link
Contributor

Hi @OriolAbril, does this issue also have a time constraint? If not, I would like to work on this issue.

@OriolAbril
Copy link
Member Author

This one also has the high impact label, but needs very little changes. Only re executing it with latest pymc and arviz and some cosmetic changes to follow the style guide: https://github.com/pymc-devs/pymc/wiki/PyMC-Jupyter-Notebook-Style-Guide

@farhanreynaldo
Copy link
Contributor

Ah sure, may I assign myself on this issue? I will try my best to make the PR as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

2 participants