-
-
Notifications
You must be signed in to change notification settings - Fork 269
Images in NBs are compressed #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh, supposedley it was fixed in #660 but still seeing it here: https://www.pymc.io/projects/examples/en/latest/gaussian_processes/HSGP-Advanced.html |
Oh, I accidentally committed the fix to main 1258d5f. Anyway that hopefully takes care of it. The issue is, I'm fairly certain, that myst-nb released 1.1.1 with the bug still present. |
The fix was definitely merged before the release 🤔. But there were a couple PRs to fix it that were merged together, maybe something went wrong. I'll reopen so we remember to check |
I re-rendered the mwe I generated for the issues and I don't see any problem with myst-nb 1.1.1: https://oriol-sphinx-playground.readthedocs.io/en/image_metadata_a/. I'll open a PR to see if 1) the PR preview renders correctly, 2) it is using the right versions |
FYI myst-nb is now on version 1.2.0 |
It looks like #791 fixes this, if anyone can double check a few notebooks to make sure it does work properly in all notebooks it would be great. Link to PR preview https://pymc-examples--791.org.readthedocs.build/en/791/ |
Looks good on the one I checked!
…On Thu, May 8, 2025 at 8:47 AM Oriol Abril-Pla ***@***.***> wrote:
*OriolAbril* left a comment (pymc-devs/pymc-examples#671)
<#671 (comment)>
It looks like #791 <#791>
fixes this, if anyone can double check a few notebooks to make sure it does
work properly in all notebooks it would be great. Link to PR preview
https://pymc-examples--791.org.readthedocs.build/en/791/
—
Reply to this email directly, view it on GitHub
<#671 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGHPTIOYVLNOQNT2S4D25NG55AVCNFSM6AAAAABYA4QZY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRSHEZTIMBWHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Images in NBs are compressed, this is a sphinx issue that popped up e.g. here:
pymc-labs/pymc-marketing#667
The text was updated successfully, but these errors were encountered: