Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing PyMC3 plots w/ Arviz plots & sigma Param change [Part 5] #23

Merged

Conversation

CloudChaoszero
Copy link
Contributor

Description

The following is a large PR breakdown of PR #16.

Replace PyMC3 dependent plots with arviz plots in case studies & examples.

Replace parameter sd with sigma (e.g. some examples have pm.Normal(...sd=...)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -6,6 +6,9 @@
"metadata": {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plot isn't displaying for some reason.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I realized I didn't properly re-run the notebook. In order to do so, I resolved issues like:

  • Specifying core param on pm.sample
  • Update submodule ref (e.g From theano.Op to theano.tensor.Op)

examples/ode_models/ODE_with_manual_gradients.ipynb Outdated Show resolved Hide resolved
examples/ode_models/ODE_with_manual_gradients.ipynb Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

review-notebook-app bot commented Mar 14, 2021

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2021-03-14T11:29:40Z
----------------------------------------------------------------

which pymc3 version is this?


CloudChaoszero commented on 2021-03-15T02:23:59Z
----------------------------------------------------------------

3.11, added it the respective print statement now :D

@review-notebook-app
Copy link

review-notebook-app bot commented Mar 14, 2021

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2021-03-14T11:29:41Z
----------------------------------------------------------------

Why is NUTS tuning failing here? maybe only try adapt_diag.


CloudChaoszero commented on 2021-03-15T02:03:48Z
----------------------------------------------------------------

Yeah, I'm unsure why as well. I get a sampling error when using adapt_diagor other adapter types....unsure why.

The error

SamplingError: Bad initial energy

in particular is in the next comment after this (seen in Github UI)

CloudChaoszero commented on 2021-03-15T03:03:20Z
----------------------------------------------------------------

Added here https://github.com//issues/43

Copy link
Contributor Author

CloudChaoszero commented Mar 15, 2021

Yeah, I'm unsure why as well. I get a sampling error when using adapt_diagor other adapter types....unsure why.

The error

SamplingError: Bad initial energy

in particular is in the next comment after this (seen in Github UI)


View entire conversation on ReviewNB

Updated after ReviewNB comment ^^^

Screen Shot 2021-03-14 at 6 56 40 PM

Copy link
Contributor Author

3.11, added it the respective print statement now :D


View entire conversation on ReviewNB

Copy link
Contributor Author

Added here https://github.com//issues/43


View entire conversation on ReviewNB

@OriolAbril OriolAbril merged commit 1ba7529 into pymc-devs:main Mar 21, 2021
@CloudChaoszero CloudChaoszero deleted the replace-pymc3-arviz-plots_part5 branch April 5, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants