SMC update #243
Merged
SMC update #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
OriolAbril
reviewed
Oct 22, 2021
| @@ -16,18 +16,19 @@ | |||
| "name": "stdout", | |||
There was a problem hiding this comment.
Line #4. np.mean(idata_04.posterior["X"] > 0).item()
not sure what this mean is doing and it looks like it's not being printed either.
Reply via ReviewNB
There was a problem hiding this comment.
It is computing the relative weight w1. I have added a string to make it clear
| @@ -16,18 +16,19 @@ | |||
| "name": "stdout", | |||
There was a problem hiding this comment.
This is a bit of a side note, but is this trace.report.nsteps lost when converting to InferenceData?
Reply via ReviewNB
There was a problem hiding this comment.
yes, but this has already been fixed in PyMC 4.0
OriolAbril
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242. The example in the notebook was outdated as it was showing sampling with the metropolis kernel which was superseeded for the independent Metropolis Hastings kernel (IMH). This also update the discussion about the diagnostics. Additionally this incorporate at least some of the recommendations from the Jupyter Notebook Style Guide.
related to #124