Item response jupyter style update

[ltoniazzi]

Updated the Item Response NBA notebook to follow the Jupyter style guidelines. Issue #217

Made modifications to adhere to the Jupyter style guidelines.

Note: I failed to resolve this warning after sampling:

UserWarning: The parameter 'updates' of aesara.function() expects an OrderedDict, got <class 'dict'>. 
Using a standard dictionary here results in non-deterministic behavior. 
You should use an OrderedDict if you are using Python 2.7 (collections.OrderedDict for older python), 
or use a list of (shared, update) pairs. Do not just convert your dictionary to this 
type before the call as the conversion will still be non-deterministic.")

• Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
• PR description contains a link to the relevant issue: a tracker one for existing notebooks or a proposal one for new notebooks
• Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

Helpful links

• https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-10T20:29:00Z
----------------------------------------------------------------

Something went wrong with the tags. And the date should be updated so it appears in the "recent updates" section

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-10T20:29:01Z
----------------------------------------------------------------

I think the graphviz won't appear if the semicolon is used.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-10T20:29:01Z
----------------------------------------------------------------

You should be able to use labeller=az.labels.NoVarLabeller() when calling the plotting function for the theta in the first row and the [] to not appear in the tick labels. I say should because the labels module is still untested, if it doesn't we'll fix whatever issue appears

ltoniazzi commented on 2022-04-12T21:58:00Z
----------------------------------------------------------------

Tried two commands but they do not seem to get rid of the brakets. You can see them in the last commit.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-10T20:29:02Z
----------------------------------------------------------------

Line #2.    top_theta_list = top_theta[:amount].coords["disadvantaged"].to_dict()["data"]

I think this is overly complicated. In general, positional indexing should not be used in xarray, because the order of the dimensions has no guarantees of being always the same. Here however the variable is already 1d because we reduced the chain and dim ones, so it is perfectly fine to use positional indexing. The selection however can be simplified to

top_theta_players = top_theta["disadvantaged"][:amount]        # to get xr.DataArray
top_theta_players = top_theta["disadvantaged"][:amount].values # to get numpy array

also, these variables with the top players, should be used further down in the plot instead of repeating the selection again.

I should have commented that on the cell above, I somehow messed it up. It applies to both, and once defined, it the variable can also be used without needing to be redefined.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-10T20:29:03Z
----------------------------------------------------------------

I did not reexecute the notebook and should not be listed here, my PR was only generating the myst views because they are helpful for reviewing but I had no real effect on the actual notebooks other than cleaning up trailing white spaces.

We also agreed that only people who authored, adapted or updated the notebook would be listed in the post directive even if everyone is listed here. The metadata from the post directive is what is used to generate the citation advise below

[ltoniazzi]

Tried two commands but they do not seem to get rid of the brakets. You can see them in the last commit.

---

View entire conversation on ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-22T21:12:38Z
----------------------------------------------------------------

Line #2.    top_theta_players = top_theta["disadvantaged"][:amount].to_dict()["data"]

What is the .to_dict()["data"] doing? I don't know what is going on and have never used that myself, but I am also positive whatever is being achieved here can be done in a simpler way. If the goal is to convert the DataArray to a numpy array, using .values does the trick for example.

ltoniazzi commented on 2022-04-23T11:52:53Z
----------------------------------------------------------------

Sorry this was a mistake that popped up when I restored the notebook

[ltoniazzi]

Sorry this was a mistake that popped up when I restored the noebook

---

View entire conversation on ReviewNB