Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Minibatch alignment in Bayesian Neural Network example + Pre-commit hooks #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wiwa
Copy link

@wiwa wiwa commented Nov 5, 2024

Fix Minibatch Alignment in Bayesian Neural Network Example + Pre-commit hooks

Issue

Fixes #654.

Changes Made

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wiwa wiwa changed the title F/fix minibatch issue Fix Minibatch alignment in Bayesian Neural Network example + Pre-commit hooks Nov 5, 2024
@wiwa wiwa marked this pull request as ready for review November 5, 2024 16:57
@@ -190,7 +190,7 @@
},
Copy link
Member

@fonnesbeck fonnesbeck Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #21.            ann_input = pm.Data("ann_input", minibatch_x, mutable=True, dims=("obs_id", "train_cols"))

mutability is True by default


Reply via ReviewNB

Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. You can remove the mutable argument or leave it -- fine with it either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in "Variational Inference: Bayesian Neural Networks" notebook
3 participants