Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on last release of PyMC instead of main #125

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 29, 2023

Otherwise it's a bit of a mess when we are changing API across releases

We might even undo changes before a release, and we shouldn't be patching the code here until it becomes "fixed".

Related to #124
Closes #123

@ricardoV94
Copy link
Member Author

ricardoV94 commented Mar 29, 2023

Why does it not find pymc5.1.2?

https://github.com/pymc-devs/pymc-experimental/actions/runs/4551538419/jobs/8025726647?pr=125

Could it be because of the defaults channel?

- conda-forge
- defaults

CC @maresb

@ricardoV94 ricardoV94 marked this pull request as draft March 29, 2023 18:44
@ricardoV94 ricardoV94 force-pushed the test_last_pymc_release branch 3 times, most recently from 0cd802c to 70256a8 Compare March 30, 2023 07:27
@ricardoV94 ricardoV94 marked this pull request as ready for review March 30, 2023 07:39
Windows returns `np.float32`, which is not an instance of `float`
@ricardoV94
Copy link
Member Author

At last :D

@ricardoV94 ricardoV94 merged commit 5259105 into pymc-devs:main Mar 30, 2023
@ricardoV94 ricardoV94 deleted the test_last_pymc_release branch July 25, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is broken
1 participant