Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marginalize continuous variable via QMC integration #353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Marginalize continuous variable via QMC integration #353

wants to merge 1 commit into from

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 27, 2024 •
edited
Loading

TODO

  • Implement QMC marginalization
  • Refactor away MarginalModel (separate PR)
    • Allow specifying desired Marginalization strategy
  • Wrap Sobol inside Op
  • Allow specifying number of QMC draws
  • Allow specifying whether QMC draws are constant

@theorashid theorashid mentioned this pull request Jun 27, 2024
Open
@ricardoV94 ricardoV94 added enhancements New feature or request marginalization labels Jul 5, 2024
@ricardoV94 @aseyboldt
@larryshamalama @zaxtax @theorashid
Add QMC marginalization
caa8b35 
Co-authored-by: Adrian Seyboldt <aseyboldt@users.noreply.github.com>
Co-authored-by: larryshamalama <larry.dong@mail.utoronto.ca>
Co-authored-by: Rob Zinkov <zaxtax@users.noreply.github.com>
Co-authored-by: theorashid <30835680+theorashid@users.noreply.github.com>
This was referenced Jul 5, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrine ferrine ferrine left review comments

@zaxtax zaxtax Awaiting requested review from zaxtax

@aseyboldt aseyboldt Awaiting requested review from aseyboldt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancements New feature or request marginalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardoV94 @ferrine