ensure a is positive

pymc-devs · Nov 10, 2023 · 052ff37 · 052ff37
1 parent b1ad63a
commit 052ff37
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pymc_experimental/distributions/continuous.py b/pymc_experimental/distributions/continuous.py
@@ -28,6 +28,7 @@
 from pymc.distributions.dist_math import check_parameters
 from pymc.distributions.distribution import Continuous
 from pymc.distributions.shape_utils import rv_size_is_none
+from pymc.logprob.utils import CheckParameterValue
 from pymc.pytensorf import floatX
 from pytensor.tensor.random.op import RandomVariable
 from pytensor.tensor.variable import TensorVariable
@@ -329,6 +330,8 @@ def maxwell_dist(a: TensorVariable, size: TensorVariable) -> TensorVariable:
         if rv_size_is_none(size):
             size = a.shape
 
+        a = CheckParameterValue("a > 0")(a, pt.all(pt.gt(a, 0)))
+
         return Chi.dist(nu=3, size=size) * a
 
     def __new__(cls, name, a, **kwargs):

diff --git a/pymc_experimental/tests/distributions/test_continuous.py b/pymc_experimental/tests/distributions/test_continuous.py
@@ -173,7 +173,6 @@ def test_logp(self):
             Rplus,
             {"a": Rplus},
             lambda value, a: sp.maxwell.logpdf(value, scale=a),
-            skip_paramdomain_outside_edge_test=True,
         )
 
     def test_logcdf(self):
@@ -182,5 +181,4 @@ def test_logcdf(self):
             Rplus,
             {"a": Rplus},
             lambda value, a: sp.maxwell.logcdf(value, scale=a),
-            skip_paramdomain_outside_edge_test=True,
         )