Skip to content

Conversation

HasnainRaz
Copy link
Contributor

Changing the name to reflect the renaming in pymc-devs/pymc@04a03b5

Otherwise importing this module raises an import error.

This need not be merged now, I am just making this PR to use the commit in my dependencies without relying on my own fork.

@ricardoV94
Copy link
Member

ricardoV94 commented Nov 24, 2023

@HasnainRaz did it fail or just raise a warning. The idea was that the old name was still importable but with a warning

https://github.com/pymc-devs/pymc/blob/04a03b520aa52c5586123f076c6377b32cf855b4/pymc/distributions/transforms.py#L63-L65

@ricardoV94
Copy link
Member

Ahh this was importing from the right place: logprob submodule. The warning was added in the user facing one... makes sense maybe

@HasnainRaz
Copy link
Contributor Author

It was failing

@ricardoV94
Copy link
Member

ricardoV94 commented Nov 25, 2023

We can now lower pin pymc to the 5.10.0 version that was just released. That is the one with the breaking change here. The tests should start passing as well (we always test against the latest release)

@ricardoV94 ricardoV94 changed the title Rename RVTransform to Transform Adapt PyMC 5.10.0 breaking changes Nov 25, 2023
@twiecki
Copy link
Member

twiecki commented Nov 27, 2023

      from pymc.pytensorf import local_remove_check_parameter

E ImportError: cannot import name 'local_remove_check_parameter' from 'pymc.pytensorf' (/usr/share/miniconda3/envs/pymc-experimental-test/lib/python3.9/site-packages/pymc/pytensorf.py)

@HasnainRaz
Copy link
Contributor Author

@ricardoV94 Seems the tests are failing because of a missing function in pymc. I lack the context to fix this, if you guys wanna push to this PR, feel free to do so

@ricardoV94 ricardoV94 merged commit 150fb0f into pymc-devs:main Nov 27, 2023
@HasnainRaz HasnainRaz deleted the update-rvtransform branch November 27, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants