Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vectorize in finite_discrete_marginal_rv_logp #337

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

ricardoV94
Copy link
Member

This should be more performant and also faster to compile due to smaller computational graphs.

I've been waiting for the vectorize functionality to mature, and I think it's good now

Copy link
Contributor

@zaxtax zaxtax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit 8158627 into pymc-devs:main Apr 21, 2024
8 checks passed
@ricardoV94 ricardoV94 deleted the vectorize_marginal_model branch April 21, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements New feature or request marginalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants