Rename to pymc-extras #404
Conversation
|
Want to also update imports/docstrings in the codebase? |
|
And the environment names in conda-envs/ I'm happy to help out with the migration |
fonnesbeck
changed the title
|
@OriolAbril anything special needed for RTD? |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
OK, that took some doing. Should be clean now. |
|
What will the new import look like? 🤔 |
|
|
|
This appears to have broken the |
|
We can live without it
|
|
This have functional changes as well? |
pymc_extras/version.py
Outdated
There was a problem hiding this comment.
Should the version number be changed since it's a new package?
There was a problem hiding this comment.
That's fine, we can continue from the old numbering. We did that with pymc and I think it's a bit easier to follow along
There was a problem hiding this comment.
Yes, it will make it obvious when the renaming occurred.
|
And just like that, tests pass. |
|
Can this be merged? |
| SteadyStateFilter | ||
| KalmanSmoother | ||
| SingleTimeseriesFilter | ||
| CholeskyFilter |
There was a problem hiding this comment.
Unrelated changes? Did you merge main instead of rebasing? Makes it a bit hard to check
There was a problem hiding this comment.
I removed these because they did not seem to exist in the code base, so tests were failing.
There was a problem hiding this comment.
I think it was a chicken and egg situation. Something got removed in one file and then kept breaking other stuff. AFAICT they still existed in main
There was a problem hiding this comment.
The cholesky, was renamed to SquareRootFilter. The others were removed as you said
|
@fonnesbeck I'm going to squash the commits and rebase to see if the github changed lines become more streamlined |
ricardoV94
force-pushed
the
readme_update
branch
from
c0df8ab to
9268d3c
Compare
|
I have never renamed a readthedocs project, not even sure if it is possible. As of now, the docs are their own rtd project: pymc-experimental Its direct url is https://pymc-experimental.readthedocs.io but it gets published as a subproject of the main pymc website which makes the actual url https://www.pymc.io/projects/experimental/en/latest/ (the other one works but redirects here). Is it ok to keep these urls or do we want those updated? If updated, even if the experimental ones break. I am not sure it will be possible to redirect, maybe if we rename and create an empty pymc-experimental rtd project (again) that only has a link/redirects to the extras one. Everything is configured from the rtd website though so nothing that needs to happen in this PR. Once you tell me which of the different options is the preferred one I'll try to make it happen |
|
@fonnesbeck I reverted all accidental functional changes I could find. |
Whatever is less work for us |
ricardoV94
force-pushed
the
readme_update
branch
from
9268d3c to
2da9ea1
Compare
|
They do! |
|
All existing PRs will have to be rebased and we should create a pypi pckage ASAP @fonnesbeck |
|
It doesn't look like we can rename pymc-experimental, so I will have to create a new project. The next version is slated to be 0.1.5 but shall we jump to 0.2.0 for this? Or dare we make this a major version? |
I would do 0.2. Maybe we'll have something very flashy for 1.0 |
Coward. |
|
OK uploaded a test here: https://test.pypi.org/project/pymc-extras/0.2.0/ If everything looks good I can do it for realz. |
Changes instances of
*-experimentalto*-extrasthroughout. Also renames the module itself, and deals with renaming on all imports. Additional cleanup as dictated by linting.