Bugfixes and Improvements for MAP and Laplace #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jessegrabowski
force-pushed
the
laplace_map_bugfixes
branch
from
966cb5a to
aa97238
Compare
|
rebased to group commits logically. I ended up touching code unrelated to the stated PR to get tests to pass, so this should not be squashed when merged. |
zaxtax
reviewed
Feb 7, 2025
Check for `jax` installation before any computation if `gradient_backend = 'jax'`
jessegrabowski
force-pushed
the
laplace_map_bugfixes
branch
from
aa97238 to
9277743
Compare
zaxtax
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically responding to suggestions by @theorashid, but the code is also quite ugly in general. I'd like to think about how it could be done better.