-
Notifications
You must be signed in to change notification settings - Fork 73
Allow exogenous regressions in BayesianSARIMAX
#566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
2c41af2 to
6a6304b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames BayesianSARIMA to BayesianSARIMAX and adds support for exogenous regressors in the model. The X suffix follows the standard convention for models with exogenous variables.
Key changes:
- Renamed the class from
BayesianSARIMAtoBayesianSARIMAX - Added support for exogenous regressors via new parameters
k_exogandexog_state_names - Implemented exogenous data handling through observation intercept modifications
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pymc_extras/statespace/models/SARIMAX.py |
Main model class renamed and exogenous regression functionality added |
tests/statespace/models/test_SARIMAX.py |
Updated tests to use new class name and added exogenous regression test |
pymc_extras/statespace/core/statespace.py |
Updated data handling for exogenous variables |
pymc_extras/statespace/models/__init__.py |
Updated imports and exports for renamed class |
pymc_extras/statespace/__init__.py |
Updated public API exports |
| Various other files | Updated references and documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Dekermanjian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jesse this looks great!
BayiesnaSARIMAXBayesianSARIMAX
Exogenous regressors are added via a time-varying observation bias to keep the statespace as small as possible.
We could consider allowing something fancier, but this is a good v0.