Rename pymc3 -> pymc #165
Merged
Rename pymc3 -> pymc #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
twiecki
approved these changes
Dec 16, 2021
savagej
reviewed
Mar 1, 2022
| @@ -10,7 +10,7 @@ | |||
| "import matplotlib.pyplot as plt\n", | |||
| "import numpy as np\n", | |||
| "import pandas as pd\n", | |||
| "import pymc3 as pm\n", | |||
| "import pymc as pm\n", | |||
There was a problem hiding this comment.
With this change, I get
AttributeError: module 'pymc' has no attribute 'trace_to_dataframe'
in code 4.32
There was a problem hiding this comment.
I tried moving over to
trace_df = az.from_pymc3(trace=trace_4_1)
but got
ModuleNotFoundError: No module named 'pymc3'
savagej
reviewed
Mar 1, 2022
| @@ -9,7 +9,7 @@ | |||
| "import arviz as az\n", | |||
| "import matplotlib.pyplot as plt\n", | |||
| "import numpy as np\n", | |||
| "import pymc3 as pm\n", | |||
| "import pymc as pm\n", | |||
There was a problem hiding this comment.
Issue with this chapter using pymc too: pymc-devs/pymc#5443
Previous commits contained the expression `Pr(positive|mortal)1 - Pr(vampire)` as part of the normalizing constant. I believe the correct expression is `Pr(positive|mortal)(1 - Pr(vampire))`. This commit corrects the markdown of the vampire normalizing constant. Co-authored-by: laj <larry.jones@reveal-energy.com>
|
Should this one be merged sooner rather than later? |
Add BMCP to resources
* Add bayes_rule env * Rename prefix * Add seaborn
* Update README.md * Update README.md Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com> * Update README.md Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
|
Good point, need to resolve conflicts @fonnesbeck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In advance of the PyMC4 beta, this PR is renaming
pymc3topymcthroughout, taking care to preserve cases likearviz.from_pymc3andbcm_pymc3which have not yet changed.