Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py says we use nose for testing, but we don't #4341

Closed
michaelosthege opened this issue Dec 14, 2020 · 1 comment · Fixed by #4374
Closed

setup.py says we use nose for testing, but we don't #4341

michaelosthege opened this issue Dec 14, 2020 · 1 comment · Fixed by #4374

Comments

@michaelosthege
Copy link
Member

Someone noticed a few weeks back that there's also a dependency on nose in one of the requirements file.

We changed to pytest and I'm not aware of any nose usage anywhere, so let's take it out.

@ColCarroll
Copy link
Member

To add historical context, this was a dependency through theano, which for reasons required it to even import the project. If pymc-theano removes that, then this should be straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants