Test on oldest supported versions during end-to-end CI #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
fixup-ci
branch
6 times, most recently
from
51232a5 to
3d8a3c1
Compare
MarcoGorelli
commented
Dec 23, 2020
.pre-commit-config.yaml
Outdated
| @@ -51,7 +51,7 @@ repos: | |||
| - id: pip-from-conda | |||
| additional_dependencies: [pyyaml] | |||
| entry: python scripts/generate_pip_deps_from_conda.py | |||
| files: ^conda-envs/ | |||
| files: ^conda-envs/environment-dev-py37\.yml$ | |||
There was a problem hiding this comment.
It's probably a good idea to have some CI jobs run with different versions of packages, to check PyMC3 works both with the oldest and with the newest versions of its dependencies. So, requirements-dev.txt now has to be generated from just one yml file
.pre-commit-config.yaml
Outdated
| @@ -42,7 +42,7 @@ repos: | |||
| name: Check no tests are ignored | |||
| pass_filenames: false | |||
| - id: conda-env-sort | |||
| additional_dependencies: [pyyaml] | |||
| additional_dependencies: [ruamel.yaml] | |||
There was a problem hiding this comment.
ruamel.yaml preserves comments (which pyyaml destroys) so switching to that
There was a problem hiding this comment.
will do this in a separate PR
MarcoGorelli
force-pushed
the
fixup-ci
branch
2 times, most recently
from
3e659c6 to
bd68baf
Compare
MarcoGorelli
force-pushed
the
fixup-ci
branch
from
bd68baf to
841d45e
Compare
twiecki
approved these changes
Dec 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #4374 +/- ##
==========================================
- Coverage 88.09% 87.80% -0.29%
==========================================
Files 88 88
Lines 14538 14305 -233
==========================================
- Hits 12807 12561 -246
- Misses 1731 1744 +13
|
twiecki
approved these changes
Jan 5, 2021
|
Thanks @MarcoGorelli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest.ymlruns all the tests. It's probably a good idea, for that job, to pin all library versions to the earliest possible supported version (as perrequirements.txt) to make sure that PyMC3 actually works with those versionswhile I was here, this closes #4341