-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarginalSparse shouldn't use DensityDist internally #5024
Comments
This would be nice to do. It would allow In the interest of keeping #5055 smaller, I think it should be done after that's in, or branched off of it in a separate PR. I might be mistaken, but I think it's more of an enhancement than something broken that must be fixed before v4. It also makes me wonder if other GP implementations would be better refactored into |
@bwengals Are you interested in pursuing this one? Or should we add a "help wanted" label? |
Closed by #6076 |
Description of your problem
The
MarginalSparse
Gaussian Process usesDensityDist
internally to compute themarginal_likelihood
(here). We should refactor that code to use a proper RandomVariable insteadVersions and main components
The text was updated successfully, but these errors were encountered: