Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EllipticalSlice for V4 #5137

Closed
ricardoV94 opened this issue Nov 5, 2021 · 1 comment · Fixed by #5756
Closed

Remove EllipticalSlice for V4 #5137

ricardoV94 opened this issue Nov 5, 2021 · 1 comment · Fixed by #5756
Labels
beginner friendly v4
Milestone
v4.0.0

Comments

@ricardoV94
Copy link
Member

This step method has not been refactored yet:

pymc/pymc3/step_methods/elliptical_slice.py

Line 103 in 3cc457b

# XXX: This needs to be refactored

@ricardoV94 ricardoV94 added the v4 label Nov 5, 2021
@ricardoV94 ricardoV94 added this to the v4.0.0-beta2 milestone Nov 5, 2021
@ricardoV94 ricardoV94 mentioned this issue Nov 5, 2021
Closed
13 tasks
@ricardoV94 ricardoV94 modified the milestones: v4.0.0b2, v4.0.0b3 Jan 7, 2022
@ricardoV94 ricardoV94 modified the milestones: v4.0.0b3, v4.0.0 Feb 3, 2022
@ricardoV94 ricardoV94 changed the title Refactor or deprecate EllipticalSlice for V4 Deprecate EllipticalSlice for V4 Mar 25, 2022
@ricardoV94 ricardoV94 changed the title Deprecate EllipticalSlice for V4 Refactor or deprecate EllipticalSlice for V4 Mar 25, 2022
@ricardoV94 ricardoV94 changed the title Refactor or deprecate EllipticalSlice for V4 Deprecate EllipticalSlice for V4 Apr 1, 2022
@ghost
Copy link

ghost commented Apr 21, 2022

Since this is something we are simply not carrying over to v4, I don't think we need to deprecate it (since it won't work and we aren't going to port it). So this will be a removal, rather than a deprecation.

@ricardoV94 ricardoV94 changed the title Deprecate EllipticalSlice for V4 Remove EllipticalSlice for V4 Apr 21, 2022
michaelosthege added a commit to michaelosthege/pymc that referenced this issue May 9, 2022
@michaelosthege
Remove EllipticalSlice sampler
7421b6e 
Closes pymc-devs#5137
@michaelosthege michaelosthege mentioned this issue May 9, 2022
Merged
ricardoV94 pushed a commit that referenced this issue May 9, 2022
@michaelosthege @ricardoV94
Remove EllipticalSlice sampler
ab593b1 
Closes #5137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly v4
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Remove EllipticalSlice sampler michaelosthege/pymc
1 participant
@ricardoV94