Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalance test allocation across jobs #6170

Closed
ricardoV94 opened this issue Oct 1, 2022 · 7 comments
Closed

Rebalance test allocation across jobs #6170

ricardoV94 opened this issue Oct 1, 2022 · 7 comments
Labels
Github CI/CD maintenance needs info Additional information required

Comments

@ricardoV94
Copy link
Member

Now that #5777 is completed many tests changed place. We should check if the jobs need to be rebalanced to have similar runtimes

@ricardoV94 ricardoV94 added Github CI/CD needs info Additional information required maintenance labels Oct 1, 2022
@ricardoV94
Copy link
Member Author

CC @michaelosthege

@ricardoV94
Copy link
Member Author

@Armavica is this something you would be interested in? It boils down to checking the last ~3 successful jobs and checking the total time each one took to try and redistribute tests from long jobs to short ones

@Armavica
Copy link
Member

Sure, I will do that.

@Armavica
Copy link
Member

Armavica commented Oct 31, 2022

Ubuntu and Windows can be rebalanced, but test_sampling.py is especially slow on Mac, and this will be the slowest runner after we rebalance Ubuntu and Windows.

tests

Looking a bit closer at the individual test durations in test_sampling.py, it looks like no particular test is hanging everything up: everything is just about twice as slow on Mac than on Ubuntu. Should I try splitting up this file with pytest -k between Mac runners? Otherwise, we won't gain much from rebalancing Windows and Ubuntu.

@ricardoV94
Copy link
Member Author

@Armavica Yeah we've noticed the Mac machines are quite slow. There were plans to split the contents of sampling.py in two files, so that might help: #6141

Otherwise we can move those tests to another platform

@Armavica
Copy link
Member

Armavica commented Oct 31, 2022

Ok thanks, I will try to find a solution.

Otherwise we can move those tests to another platform

They are actually being tested on all three platforms (and a fourth time on windows with float32).

@Armavica Armavica mentioned this issue Nov 4, 2022
5 tasks
@Armavica
Copy link
Member

Armavica commented Nov 5, 2022

To try and see through the variability of the GitHub runners, I put together a hierarchical model and analyzed the last 9 runs. It is not perfect but it seems consistent with what I usually observe. This will help to rebalance the tests.

Two things to note:

  • The macos runners are indeed about 2-2.5x as slow as the Windows or Linux ones
  • Besides the OS, there remains indeed a large variability at the instance level, of about two natural orders of magnitude (~x7).

results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github CI/CD maintenance needs info Additional information required
Projects
None yet
Development

No branches or pull requests

2 participants