-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror codebase structure in tests #5777
Labels
Comments
I can't see any. Aesara also has their tests outside of the code directory. |
This was referenced Sep 9, 2022
@Armavica do you want to open a discussion for moving the tests out of pymc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #5579
Originally posted by ricardoV94 March 11, 2022
I think the tests files should mirror the original codebase. So they should be in a file with the same name as where the functions/classes that it tests are defined. E.g.,, timeseries tests should be in tests/distributions/test_timeseries.py. This is how Aesara does it and its much easier to find what tests relate to what code, and also to spot gaps in our tests.
Originally posted by @ricardoV94 in #5298 (comment)
This would also allow to break up the immensely large and slow
test_distributions.py
, which was already brought up in #5410 (comment)Also, #5577 (comment)
The text was updated successfully, but these errors were encountered: