-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the test suite to follow the code #6111
Conversation
c63d518
to
c56ecb1
Compare
c56ecb1
to
9c68059
Compare
Codecov Report
@@ Coverage Diff @@
## main #6111 +/- ##
==========================================
+ Coverage 92.08% 92.69% +0.61%
==========================================
Files 86 99 +13
Lines 17861 20531 +2670
==========================================
+ Hits 16447 19032 +2585
- Misses 1414 1499 +85
|
I didn't touch yet: I looked at |
|
||
|
||
def test_posdef_symmetric3(): | ||
"""The test return 0 if the matrix has 0 eigenvalue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""The test return 0 if the matrix has 0 eigenvalue. | |
"""The test returns 0 if the matrix has 0 eigenvalue. |
@@ -1874,3 +1875,28 @@ def test_car_rng_fn(sparse): | |||
) | |||
f -= 1 | |||
assert p > delta | |||
|
|||
|
|||
def test_posdef_symmetric1(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know youre just restructuring these so this isnt required, just commenting. Would be nice to paramterizing these
|
I don't think that it uses anything from |
looked through this and it LGTM. coverage is showing more test coverage as well. we should merge before theres any conflicts that arise and follow up in prs imo |
Lets do this in another PR to save you rebase headache. This many files changed always make me nervous and rebasing across file changes is a real pain |
Thanks much @Armavica |
What is this PR about?
This PR splits up several test files as discussed in #5777.
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance