Return an empty string for empty model representation #5577
Conversation
ricardoV94
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5577 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 76 76
Lines 13702 13704 +2
=======================================
+ Hits 12001 12003 +2
Misses 1701 1701
|
pymc/printing.py
Outdated
| @@ -58,6 +58,9 @@ def str_for_dist(rv: TensorVariable, formatting: str = "plain", include_params: | |||
| def str_for_model(model: Model, formatting: str = "plain", include_params: bool = True) -> str: | |||
| """Make a human-readable string representation of Model, listing all random variables | |||
| and their distributions, optionally including parameter values.""" | |||
| if len(model.unobserved_RVs) + len(model.observed_RVs) + len(model.potentials) == 0: | |||
There was a problem hiding this comment.
Instead of adding this verbose if statement you can check if rv_reprs below is an empty list before going into the the if "latex"... else statement.
There was a problem hiding this comment.
Thanks for the feedback. I have one question. There doesn't seem to be any existing test for this function so I am not sure in which file to write the test. Should I create a new test_printing file for just this one test or is there any existing file where I can add it?
There was a problem hiding this comment.
Good question. That relates to #5579, in the meantime you can perhaps add it to test_model.py?
|
Thanks @sagartomar! |
… instead of raising an error
Should fix #5568
Thank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description: