Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename moment to finite_logp_point #6974

Closed
ricardoV94 opened this issue Oct 26, 2023 · 0 comments · Fixed by #7166
Closed

Rename moment to finite_logp_point #6974

ricardoV94 opened this issue Oct 26, 2023 · 0 comments · Fixed by #7166
Labels
maintenance

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Oct 26, 2023 •
edited
Loading

Description

The name moment has raised confusion a couple of times, recently in #6804

What that function is supposed to do is to return a point at which the distribution logp is finite (if any point exists).
This is often the mean or mode, but need not always be. We should rename it accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename moment to support_point aerubanov/pymc3
1 participant
@ricardoV94