Rename moment to support_point
#7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7166 +/- ##
==========================================
- Coverage 92.29% 92.26% -0.04%
==========================================
Files 101 101
Lines 16947 16966 +19
==========================================
+ Hits 15642 15653 +11
- Misses 1305 1313 +8
|
aerubanov
force-pushed
the
rename-moment-method
branch
from
3bb5b5b to
4813f2d
Compare
|
I renamed |
|
@ricardoV94 could you please take a look? |
|
@aerubanov great work. I have some suggestions, let me know what you think:
|
ricardoV94
added
maintenance
major
|
@ricardoV94 your suggestions sounds good, will implement it |
ricardoV94
reviewed
Feb 27, 2024
| @@ -653,34 +653,34 @@ def check_selfconsistency_discrete_logcdf( | |||
| ) | |||
|
|
|||
|
|
|||
| def assert_moment_is_expected(model, expected, check_finite_logp=True): | |||
| def assert_support_point_is_expected(model, expected, check_finite_logp=True): | |||
There was a problem hiding this comment.
This is also user facing (in that we use this utility in other libraries), so should also add a wrapper with a deprecation warning.
There was a problem hiding this comment.
I added option for using old name
ricardoV94
approved these changes
Feb 28, 2024
ricardoV94
changed the title
moment to support_point
mkusnetsov
pushed a commit
to mkusnetsov/pymc
that referenced
this pull request
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename
momentmethod to avoid confusion with distribution mean.Related Issue
momenttofinite_logp_point#6974Checklist
momentmethod in code (and other related variable names)Type of change
📚 Documentation preview 📚: https://pymc--7166.org.readthedocs.build/en/7166/