Allow user defined potentials for hmc #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseyboldt
force-pushed
the
arbitrary-pots
branch
from
1cca71b to
b803ff7
Compare
twiecki
reviewed
Feb 3, 2017
pymc3/step_methods/hmc/base_hmc.py
Outdated
Member
There was a problem hiding this comment.
I think this should be outside, quad_potential(), no? Also, I think better to be explicit here, i.e. :if potential is not None: self.potential = potential.
twiecki
reviewed
Feb 3, 2017
aseyboldt
force-pushed
the
arbitrary-pots
branch
from
b803ff7 to
2a91316
Compare
aseyboldt
force-pushed
the
arbitrary-pots
branch
from
2a91316 to
2e0c5fa
Compare
Member
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymc3 should pass user defined potentials to hmc. This used to be in #1747.