Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Convert zero-inflated distributions to Mixture subclasses #2246

Closed
wants to merge 6 commits into from

Conversation

fonnesbeck
Copy link
Member

Replaces #2231, which I messed up.

@AustinRochford
Copy link
Member

The test_scalar_shape errors would seem to be due to the use of size here.

@AustinRochford
Copy link
Member

I will continue working through the other sampling errors when I get the chance this week; the nan for the total probability of ZeroInflatedBinomial is still puzzling to me.

1 similar comment
@AustinRochford
Copy link
Member

I will continue working through the other sampling errors when I get the chance this week; the nan for the total probability of ZeroInflatedBinomial is still puzzling to me.

@fonnesbeck
Copy link
Member Author

If it doesnt work out we can always pull the plug and go back to the zero-inflated subclasses of Discrete. Less elegant, but they passed the tests with flying colors.

@AustinRochford
Copy link
Member

@fonnesbeck yes, I was thinking that it makes sense to put ZIB in the old way. I understand the problem now and think I can refactor Mixture to make it easier to change in the future, but it will take a while

@fonnesbeck
Copy link
Member Author

fonnesbeck commented May 31, 2017

OK, I will change this to a WIP and create a PR with the working zero-inflated classes. We can target this for post-3.1.

@fonnesbeck fonnesbeck changed the title Convert zero-inflated distributions to Mixture subclasses WIP: Convert zero-inflated distributions to Mixture subclasses May 31, 2017
@twiecki twiecki added the WIP label Jun 1, 2017
@twiecki
Copy link
Member

twiecki commented Dec 22, 2018

Closing because of age. Feel free to reopen if you want to fix this up.

@twiecki twiecki closed this Dec 22, 2018
@fonnesbeck fonnesbeck deleted the zero_inflated_mixture branch March 29, 2021 14:45
@ricardoV94 ricardoV94 mentioned this pull request May 11, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants