Skip to content

Conversation

@aseyboldt
Copy link
Member

Since theano doesn't compute test values outside the model context anymore, we need to do all model.logpt computations inside the model context. This lead to errors in the getting_started notebook, when it used find_MAP outside of the context. This used model.logpt which got cached without test values. This led to an exception in a later sampling statement.

Copy link
Member

@junpenglao junpenglao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twiecki twiecki merged commit fc20e31 into pymc-devs:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants