Skip to content

Add float32 tests to travis #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twiecki merged 12 commits into from
Jun 6, 2017
Merged

Add float32 tests to travis #2264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bd7a019
add float32 tests
kyleabeauchamp Jun 3, 2017
2608f4e
Try again
kyleabeauchamp Jun 3, 2017
56fb1a1
Use correct quotes
kyleabeauchamp Jun 3, 2017
3a49643
Try full grid of py27, 36, and floatX
kyleabeauchamp Jun 3, 2017
d836a91
More fixes for float32
kyleabeauchamp Jun 5, 2017
ac49fb7
Merge remote-tracking branch 'upstream/master' into flags
kyleabeauchamp Jun 5, 2017
5ae1460
Merge branch 'flags' of github.com:kyleabeauchamp/pymc3 into flags
kyleabeauchamp Jun 5, 2017
507ce8e
Merge remote-tracking branch 'upstream/master' into flags
kyleabeauchamp Jun 6, 2017
5cb850a
Fix precision in test
kyleabeauchamp Jun 6, 2017
efac938
Skip two more tests
kyleabeauchamp Jun 6, 2017
adacf81
Fix another test
kyleabeauchamp Jun 6, 2017
65bca33
Fix another test
kyleabeauchamp Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,15 @@ install:
- pip install coveralls pylint

env:
- PYTHON_VERSION=2.7 TESTCMD="--durations=10 --ignore=pymc3/tests/test_examples.py --cov-append --ignore=pymc3/tests/test_distributions_random.py --ignore=pymc3/tests/test_variational_inference.py --ignore=pymc3/tests/test_shared.py --ignore=pymc3/tests/test_smc.py --ignore=pymc3/tests/test_updates.py"
- PYTHON_VERSION=2.7 RUN_PYLINT="true" TESTCMD="--durations=10 --cov-append pymc3/tests/test_distributions_random.py pymc3/tests/test_shared.py pymc3/tests/test_smc.py"
- PYTHON_VERSION=2.7 TESTCMD="--durations=10 --cov-append pymc3/tests/test_examples.py pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py"
- PYTHON_VERSION=3.6 TESTCMD="--durations=10 --cov-append --ignore=pymc3/tests/test_examples.py --ignore=pymc3/tests/test_distributions_random.py --ignore=pymc3/tests/test_variational_inference.py --ignore=pymc3/tests/test_shared.py --ignore=pymc3/tests/test_smc.py --ignore=pymc3/tests/test_updates.py"
- PYTHON_VERSION=3.6 TESTCMD="--durations=10 --cov-append pymc3/tests/test_distributions_random.py pymc3/tests/test_shared.py pymc3/tests/test_smc.py"
- PYTHON_VERSION=3.6 TESTCMD="--durations=10 --cov-append pymc3/tests/test_examples.py pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py"
- PYTHON_VERSION=2.7 FLOATX='float32' TESTCMD="--durations=10 --ignore=pymc3/tests/test_examples.py --cov-append --ignore=pymc3/tests/test_distributions_random.py --ignore=pymc3/tests/test_variational_inference.py --ignore=pymc3/tests/test_shared.py --ignore=pymc3/tests/test_smc.py --ignore=pymc3/tests/test_updates.py"
- PYTHON_VERSION=2.7 FLOATX='float32' RUN_PYLINT="true" TESTCMD="--durations=10 --cov-append pymc3/tests/test_distributions_random.py pymc3/tests/test_shared.py pymc3/tests/test_smc.py"
- PYTHON_VERSION=2.7 FLOATX='float32' TESTCMD="--durations=10 --cov-append pymc3/tests/test_examples.py pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py"
- PYTHON_VERSION=2.7 FLOATX='float64' TESTCMD="--durations=10 --ignore=pymc3/tests/test_examples.py --cov-append --ignore=pymc3/tests/test_distributions_random.py --ignore=pymc3/tests/test_variational_inference.py --ignore=pymc3/tests/test_shared.py --ignore=pymc3/tests/test_smc.py --ignore=pymc3/tests/test_updates.py"
- PYTHON_VERSION=2.7 FLOATX='float64' RUN_PYLINT="true" TESTCMD="--durations=10 --cov-append pymc3/tests/test_distributions_random.py pymc3/tests/test_shared.py pymc3/tests/test_smc.py"
- PYTHON_VERSION=2.7 FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_examples.py pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py"
- PYTHON_VERSION=3.6 FLOATX='float64' TESTCMD="--durations=10 --cov-append --ignore=pymc3/tests/test_examples.py --ignore=pymc3/tests/test_distributions_random.py --ignore=pymc3/tests/test_variational_inference.py --ignore=pymc3/tests/test_shared.py --ignore=pymc3/tests/test_smc.py --ignore=pymc3/tests/test_updates.py"
- PYTHON_VERSION=3.6 FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_distributions_random.py pymc3/tests/test_shared.py pymc3/tests/test_smc.py"
- PYTHON_VERSION=3.6 FLOATX='float64' TESTCMD="--durations=10 --cov-append pymc3/tests/test_examples.py pymc3/tests/test_variational_inference.py pymc3/tests/test_updates.py"
script:
- . ./scripts/test.sh $TESTCMD

Expand Down
4 changes: 4 additions & 0 deletions pymc3/tests/backend_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from pymc3.tests import models
from pymc3.backends import base
import pytest
import theano


class ModelBackendSetupTestCase(object):
Expand Down Expand Up @@ -227,6 +228,7 @@ def record_point(self, val):
else:
self.strace.record(point=point)

@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32")
def test_standard_close(self):
for idx in range(self.draws):
self.record_point(idx)
Expand Down Expand Up @@ -266,13 +268,15 @@ class SelectionTestCase(ModelBackendSampledTestCase):
- shape
"""

@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32")
def test_get_values_default(self):
for varname in self.test_point.keys():
expected = np.concatenate([self.expected[chain][varname]
for chain in [0, 1]])
result = self.mtrace.get_values(varname)
npt.assert_equal(result, expected)

@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32")
def test_get_values_nocombine_burn_keyword(self):
burn = 2
for varname in self.test_point.keys():
Expand Down
4 changes: 2 additions & 2 deletions pymc3/tests/test_distributions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ def test_bound_normal(self):
PositiveNormal = Bound(Normal, lower=0.)
self.pymc3_matches_scipy(PositiveNormal, Rplus, {'mu': Rplus, 'sd': Rplus},
lambda value, mu, sd: sp.norm.logpdf(value, mu, sd),
decimal=select_by_precision(float64=6, float32=0))
decimal=select_by_precision(float64=6, float32=-1))
Copy link
Member

@twiecki twiecki Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy that float32 matches so little...

with Model(): x = PositiveNormal('x', mu=0, sd=1, transform=None)
assert np.isinf(x.logp({'x':-1}))

Expand All @@ -445,7 +445,7 @@ def test_flat(self):
def test_normal(self):
self.pymc3_matches_scipy(Normal, R, {'mu': R, 'sd': Rplus},
lambda value, mu, sd: sp.norm.logpdf(value, mu, sd),
decimal=select_by_precision(float64=6, float32=2)
decimal=select_by_precision(float64=6, float32=1)
)

def test_half_normal(self):
Expand Down
7 changes: 7 additions & 0 deletions pymc3/tests/test_sqlite_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@
from pymc3.tests import backend_fixtures as bf
from pymc3.backends import ndarray, sqlite
import tempfile
import pytest
import theano

DBNAME = os.path.join(tempfile.gettempdir(), 'test.db')


@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32 due to inf issues")
class TestSQlite0dSampling(bf.SamplingTestCase):
backend = sqlite.SQLite
name = DBNAME
Expand All @@ -18,12 +21,14 @@ class TestSQlite1dSampling(bf.SamplingTestCase):
shape = 2


@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32 due to inf issues")
class TestSQlite2dSampling(bf.SamplingTestCase):
backend = sqlite.SQLite
name = DBNAME
shape = (2, 3)


@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32 due to inf issues")
class TestSQLite0dSelection(bf.SelectionTestCase):
backend = sqlite.SQLite
name = DBNAME
Expand All @@ -42,13 +47,15 @@ class TestSQLite2dSelection(bf.SelectionTestCase):
shape = (2, 3)


@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32 due to inf issues")
class TestSQLiteDumpLoad(bf.DumpLoadTestCase):
backend = sqlite.SQLite
load_func = staticmethod(sqlite.load)
name = DBNAME
shape = (2, 3)


@pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32 due to inf issues")
class TestNDArraySqliteEquality(bf.BackendEqualityTestCase):
backend0 = ndarray.NDArray
name0 = None
Expand Down
2 changes: 1 addition & 1 deletion scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

THEANO_FLAGS='gcc.cxxflags="-march=core2"' pytest -v --cov=pymc3 "$@"
THEANO_FLAGS="floatX=${FLOATX},gcc.cxxflags='-march=core2'" pytest -v --cov=pymc3 "$@"

if [[ "$RUN_PYLINT" == "true" ]]; then
. ./scripts/lint.sh
Expand Down