Skip to content

Conversation

@ferrine
Copy link
Member

@ferrine ferrine commented Jul 6, 2017

#docathon!

@junpenglao
Copy link
Member

junpenglao commented Jul 10, 2017

I dont have enough expertise of VI to judge the content, but I think (personally at least) it would be great to see how it works for an actual implementation showing how to "constructs loss from given Model, Approximation and Test Function". It would be ideal for example, since you are working on Normalizing flow, given a simple pymc3 model, how NF constructs loss from this model, how NF approximate the parameters, etc. By pointing to specific part of the code or using code snippet, it would be much easier to understand if I want to implement a new class of VI, how can it fit into the OPVI API.

@twiecki
Copy link
Member

twiecki commented Jul 10, 2017

I've read through it and it looks great. I agree with @junpenglao that there could be a few more examples.

@twiecki twiecki added this to the 3.2 milestone Jul 14, 2017
@junpenglao
Copy link
Member

@ferrine Maybe this should be rewritten after #2416?

@ferrine
Copy link
Member Author

ferrine commented Aug 5, 2017

Ye, this refactoring has very large diff

@twiecki
Copy link
Member

twiecki commented Oct 24, 2017

@ferrine What about this one? Should we still try to merge it?

@ferrine
Copy link
Member Author

ferrine commented Oct 24, 2017

Don't think so, I've made docs with docstrings in GSoC. In my opinion that's quite enough to dive in for a new developer. And as we are about moving to new backend I don't expect future development of variational module.

@twiecki twiecki closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants