Add wrong-import-order to pylintrc. accidentally a lot of other fixes. #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpenglao
reviewed
Jul 11, 2017
pymc3/step_methods/gibbs.py
Outdated
Member
There was a problem hiding this comment.
Maybe this can be removed as well now following #2405 (comment)
Member
Author
There was a problem hiding this comment.
Same answer as below -- I'd rather do that in a different PR.
junpenglao
reviewed
Jul 11, 2017
pymc3/step_methods/hmc/hmc.py
Outdated
Member
There was a problem hiding this comment.
remove as well (reason above)
junpenglao
reviewed
Jul 11, 2017
pymc3/step_methods/smc.py
Outdated
Member
There was a problem hiding this comment.
remove as well (reason above)
junpenglao
reviewed
Jul 11, 2017
Member
Author
There was a problem hiding this comment.
I'd want to check on that carefully -- so long as we support python2, this makes sure 2 / 3 != 0. I've never counted on this myself (choosing to explicitly cast), but I think that would be for a different PR.
junpenglao
reviewed
Jul 11, 2017
pymc3/tests/test_distributions.py
Outdated
junpenglao
reviewed
Jul 11, 2017
ColCarroll
force-pushed
the
wrong_import_order
branch
from
e0a7df7 to
4ff9e9c
Compare
Member
Author
|
Would be easier to start this new at this point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new check to
.pylintrc, in response to a comment on #2405. Went through a lot of files and also corrected a bunch of linter errors which makes this a bigger change than is probably good.All changes should be cosmetic (except one undefined
_log), and are, in roughly descending order of frequency:lorI