-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forestplot: support multiple traces #2736
Conversation
It would be cool to do something to make the models stand out, such as colorize the labels by model. Conversely, I wonder if you could create shading bands to isolate the same parameters. |
I agree, the plot is too flat. I will try to do something to make the models stand out... maybe a color per-model and also the "shading-bands" |
Shading bands are used to help visualize groups of parameters (only when more than one trace is passed). Additionally, by setting Previous plots were done with the style I generally use, i.e. |
WOW this is really nice! |
Yeah, that's exactly what I had in mind. Nice work. |
Should I also add this to the release-notes? |
Is this ready to squash and merge or maybe more work is needed? |
This is really a nitpick but is it possible to adjust the shadow to more in the middle between two errorbars? |
No nitpicking at all @junpenglao! This is how it looks with your suggestion. |
Thanks @aloctavodia ! |
* forestplot: support multiple traces * add shading bands per variable and colors per model * add to release-notes * set default model names is None passed, check number of models names for consistency * ensure valid color names * place bands inbetween errorbars
Sometimes is useful to visually compare the results/posterior for different models. One option to achieve this task is to make a forestplot for all variables in all models. This PR modifies
forestplot
to support either a trace or a list of traces, a new keywordmodels
can be used to pass the names of the modelsThis is an example of a forestplot for several models:
model
m0
does not have a beta parameter, contrary to modelsm1
andm2
. Additionally, the beta parameter form2
hasshape=2
.