Fix max_treedepth warning #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is good for now. We can integrate the warning from STAN and fine tune it before 3.4. |
junpenglao
approved these changes
Jan 18, 2018
| @@ -177,8 +177,9 @@ def warnings(self, strace): | |||
| WarningType.DIVERGENCES, msg, 'error', None, None, None) | |||
| warnings.append(warning) | |||
| elif n_divs > 0: | |||
| message = ('Divergences after tuning. Increase `target_accept` or ' | |||
| 'reparameterize.') | |||
| message = ('There were %s divergences after tuning. Increase ' | |||
There was a problem hiding this comment.
Thank you for putting this back!
aseyboldt
force-pushed
the
fix-warnings
branch
from
4f8e59c to
24a835c
Compare
aseyboldt
force-pushed
the
fix-warnings
branch
from
24a835c to
3d95880
Compare
jordan-melendez
pushed a commit
to jordan-melendez/pymc3
that referenced
this pull request
Feb 6, 2018
* Fix max_treedepth warning * Less sensitive neff warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2800
Also, make the error at <25% effective sample size a info and add a warning at <10%.
cc @junpenglao Do you think that is ok, or is the 25% still too much?