Made Broken Pipe Error more verbose #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istently with scipy.stats. Added test and updated example code.
…at py27 joblib does not make tests fail
…ed release notes.
|
This is great! Needs a rebase. |
twiecki
reviewed
Dec 22, 2018
RELEASE-NOTES.md
Outdated
| @@ -34,6 +34,7 @@ | |||
| - Fixed `Rice` distribution, which inconsistently mixed two parametrizations (#3286). | |||
| - `Rice` distribution now accepts multiple parameters and observations and is usable with NUTS (#3289). | |||
| - `sample_posterior_predictive` no longer calls `draw_values` to initialize the shape of the ppc trace. This called could lead to `ValueError`'s when sampling the ppc from a model with `Flat` or `HalfFlat` prior distributions (Fix issue #3294). | |||
| - Made `BrokenPipeError` for parallel sampling more verbose on Windows. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sampling with more than 1 core on Windows os uses process spawning instead of forking. While the processes are being spawned, they are completely independent from the main process (the parent) and are unaware of how to communicate any error with the parent. This means that errors raised during the spawning, such as unpickling errors, lack of
if __name__ == "__main__"statements and potentially other problems are not informed to the main process, which can only see that the communication pipe with its children is broken. This PR ONLY changes the main process' error message because there is no way that it can know what happened to the errored spawn.