Fix Categorical.logp with take_along_axis #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianopaz
force-pushed
the
take_along_axis
branch
from
55b30eb
to
acb4a25
Compare
ColCarroll
approved these changes
Aug 16, 2019
| return tuple(fancy_index) | ||
|
|
||
|
|
||
| if hasattr(np, "take_along_axis"): |
There was a problem hiding this comment.
Suggested change
| if hasattr(np, "take_along_axis"): | |
| # np.take_along_axis added in 1.18.0, so | |
| # this can be removed once this version of numpy is required | |
| if hasattr(np, "take_along_axis"): |
|
looks good to merge once release notes are updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is essentially the same as #3563 but using
take_along_axisinstead oftt.choosein order to prevent the issues #3564 and #3567. The minor problem was thattake_along_axisis implemented innumpybut not intheano, so I had to add a port of numpy's implementation to theano in ourtheanof.pyscript. I also added tests for the new theanof parts (these should be upstream in theano itself but given that theano is dead and they wont be cutting releases I think that it's better to keeptake_along_axishere). This PR fixes #3535.