Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce number of logp evaluations #3600

Merged
merged 2 commits into from
Aug 21, 2019
Merged

reduce number of logp evaluations #3600

merged 2 commits into from
Aug 21, 2019

Conversation

aloctavodia
Copy link
Member

I realized we were doing redundant logp evaluations (one per particle per stage). This fix it.

lucianopaz
lucianopaz reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into the release notes? Is there some kind of test that could be added?

@aloctavodia
Copy link
Member Author

I could add it a line in the release notes, I guess there is no need of a new test.

@lucianopaz lucianopaz merged commit b499c73 into pymc-devs:master Aug 21, 2019
@aloctavodia aloctavodia deleted the smc_lh branch August 21, 2019 20:24
@aloctavodia aloctavodia mentioned this pull request Aug 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianopaz lucianopaz lucianopaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloctavodia @lucianopaz