Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return_inferencedata option for pm.sample #3911

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a00fff8
mention arviz functions by name in warning
michaelosthege May 4, 2020
6dec963
convert to InferenceData already in sample function
michaelosthege May 4, 2020
7c4ae31
fix refactoring bugs
michaelosthege May 4, 2020
653e3d2
fix indentation
michaelosthege May 4, 2020
7789c2c
add return_inferencedata option
michaelosthege May 4, 2020
d2b312f
Fix numpy docstring format.
rpgoldman May 4, 2020
1c558d4
pass model to from_pymc3 because of deprecation warning
michaelosthege May 4, 2020
2cf5e54
add test for return_inferencedata option
michaelosthege May 4, 2020
bb3aef0
Merge branch 'master' into return-inferencedata-option
michaelosthege May 4, 2020
67d9c58
advise against keeping warmup draws in a MultiTrace
michaelosthege May 4, 2020
c910221
mention #3911
michaelosthege May 4, 2020
0a06da1
Merge branch 'return-inferencedata-option' of https://github.com/mich…
michaelosthege May 4, 2020
fea82e1
pin to arviz 0.8.0 and address review feedback
michaelosthege May 23, 2020
d5063f2
rerun/update notebook to show inferencedata trace
michaelosthege May 23, 2020
1f42f92
Merge branch 'master' into return-inferencedata-option
michaelosthege May 23, 2020
d95880d
fix typo
michaelosthege May 23, 2020
b7471a8
make all from_pymc3 accessible to the user
michaelosthege May 23, 2020
165cbf7
Merge branch 'return-inferencedata-option' of https://github.com/mich…
michaelosthege May 23, 2020
dee0870
remove duplicate entry, and wording
michaelosthege May 23, 2020
7b083ed
address review feedback
michaelosthege May 23, 2020
96a2387
update arviz to 0.8.1 because of bugfix
michaelosthege May 25, 2020
6ff17a2
incorporate review feedback
michaelosthege May 25, 2020
fa324ff
use arviz plot_ppc
michaelosthege May 25, 2020
9d208c4
also ignore Visual Studio cache
michaelosthege May 26, 2020
d154a04
fix warmup saving logic and test
michaelosthege May 26, 2020
2912825
require latest ArviZ patch
michaelosthege May 26, 2020
50d7588
change warning to nuget users towards InferenceData
michaelosthege May 26, 2020
ff7e1ea
update ArviZ minimum version
michaelosthege May 26, 2020
e698387
address review feedback
michaelosthege May 26, 2020
3f6aafd
start showing the FutureWarning about return_inferencedata in minor r…
michaelosthege May 26, 2020
0f756e3
require arviz>=0.8.3 for latest bugfix
michaelosthege May 28, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ benchmarks/html/
benchmarks/results/
.pytest_cache/

# VSCode
# Visual Studio / VSCode
.vs/
.vscode/
.mypy_cache

Expand Down
5 changes: 4 additions & 1 deletion RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- GP covariance functions can now be exponentiated by a scalar. See PR [#3852](https://github.com/pymc-devs/pymc3/pull/3852)
- `sample_posterior_predictive` can now feed on `xarray.Dataset` - e.g. from `InferenceData.posterior`. (see [#3846](https://github.com/pymc-devs/pymc3/pull/3846))
- `SamplerReport` (`MultiTrace.report`) now has properties `n_tune`, `n_draws`, `t_sampling` for increased convenience (see [#3827](https://github.com/pymc-devs/pymc3/pull/3827))
- `pm.sample(..., return_inferencedata=True)` can now directly return the trace as `arviz.InferenceData` (see [#3911](https://github.com/pymc-devs/pymc3/pull/3911))
- `pm.sample` now has support for adapting dense mass matrix using `QuadPotentialFullAdapt` (see [#3596](https://github.com/pymc-devs/pymc3/pull/3596), [#3705](https://github.com/pymc-devs/pymc3/pull/3705), [#3858](https://github.com/pymc-devs/pymc3/pull/3858), and [#3893](https://github.com/pymc-devs/pymc3/pull/3893)). Use `init="adapt_full"` or `init="jitter+adapt_full"` to use.
- `Moyal` distribution added (see [#3870](https://github.com/pymc-devs/pymc3/pull/3870)).
- `pm.LKJCholeskyCov` now automatically computes and returns the unpacked Cholesky decomposition, the correlations and the standard deviations of the covariance matrix (see [#3881](https://github.com/pymc-devs/pymc3/pull/3881)).
Expand All @@ -20,6 +21,8 @@

### Maintenance
- Tuning results no longer leak into sequentially sampled `Metropolis` chains (see #3733 and #3796).
- We'll deprecate the `Text` and `SQLite` backends and the `save_trace`/`load_trace` functions, since this is now done with ArviZ. (see [#3902](https://github.com/pymc-devs/pymc3/pull/3902))
- ArviZ `v0.8.3` is now the minimum required version
- In named models, `pm.Data` objects now get model-relative names (see [#3843](https://github.com/pymc-devs/pymc3/pull/3843)).
- `pm.sample` now takes 1000 draws and 1000 tuning samples by default, instead of 500 previously (see [#3855](https://github.com/pymc-devs/pymc3/pull/3855)).
- Moved argument division out of `NegativeBinomial` `random` method. Fixes [#3864](https://github.com/pymc-devs/pymc3/issues/3864) in the style of [#3509](https://github.com/pymc-devs/pymc3/pull/3509).
Expand All @@ -33,7 +36,7 @@

### Deprecations
- Remove `sample_ppc` and `sample_ppc_w` that were deprecated in 3.6.
- Deprecated `sd` in version 3.7 has been replaced by `sigma` now raises `DeprecationWarning` on using `sd` in continuous, mixed and timeseries distributions. (see [#3837](https://github.com/pymc-devs/pymc3/pull/3837) and [#3688](https://github.com/pymc-devs/pymc3/issues/3688)).
- Deprecated `sd` has been replaced by `sigma` (already in version 3.7) in continuous, mixed and timeseries distributions and now raises `DeprecationWarning` when `sd` is used. (see [#3837](https://github.com/pymc-devs/pymc3/pull/3837) and [#3688](https://github.com/pymc-devs/pymc3/issues/3688)).
- We'll deprecate the `Text` and `SQLite` backends and the `save_trace`/`load_trace` functions, since this is now done with ArviZ. (see [#3902](https://github.com/pymc-devs/pymc3/pull/3902))
- Dropped some deprecated kwargs and functions (see [#3906](https://github.com/pymc-devs/pymc3/pull/3906))
- Dropped the outdated 'nuts' initialization method for `pm.sample` (see [#3863](https://github.com/pymc-devs/pymc3/pull/3863)).
Expand Down
Loading