-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add n_draws and t_sampling report to smc #3931
Conversation
@aloctavodia I'm sorry, my last edit broke your PR. I tried to set |
@michaelosthege @AlexAndorra Tests are passing for SMC and failing for other samplers |
@aloctavodia, I think the tests are failing because of the bug in io_pymc in ArviZ. This is fixed on master. Do we wait for the ArviZ bugfix-release to relaunch the tests? |
Bugfig release for ArviZ is out, however, other samplers failing is probably because they do not have n_tune,... in report. ArviZ won't fail anymore, but save warmup won't work for these samplers |
Yeah, seems like the problem is a mix of n_tune absent and n_draws being None when the trace is sliced manually -- Michael opened a PR about this. |
Adds
trace.report_n_draw
mainly to allow ArviZ to work with a trace from SMC, also adds_t_sampling
, because having access to the sampling time is nice :-)Fixes #3928