Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add n_draws and t_sampling report to smc #3931

Merged
merged 5 commits into from
May 25, 2020

Conversation

aloctavodia
Copy link
Member

@aloctavodia aloctavodia commented May 22, 2020

Adds trace.report_n_draw mainly to allow ArviZ to work with a trace from SMC, also adds _t_sampling, because having access to the sampling time is nice :-)

Fixes #3928

@michaelosthege
Copy link
Member

@aloctavodia I'm sorry, my last edit broke your PR. I tried to set _n_tune, but used a n_tune variable that does not exist.
I just checked it out, but I don't understand how the tuning works, so I don't know how to fix it =(

@aloctavodia
Copy link
Member Author

@michaelosthege @AlexAndorra Tests are passing for SMC and failing for other samplers

@AlexAndorra
Copy link
Contributor

@aloctavodia, I think the tests are failing because of the bug in io_pymc in ArviZ. This is fixed on master. Do we wait for the ArviZ bugfix-release to relaunch the tests?

@OriolAbril
Copy link
Member

Bugfig release for ArviZ is out, however, other samplers failing is probably because they do not have n_tune,... in report. ArviZ won't fail anymore, but save warmup won't work for these samplers

@AlexAndorra
Copy link
Contributor

Yeah, seems like the problem is a mix of n_tune absent and n_draws being None when the trace is sliced manually -- Michael opened a PR about this.

@aloctavodia aloctavodia merged commit 30d28f4 into pymc-devs:master May 25, 2020
@aloctavodia aloctavodia deleted the smc_report branch May 25, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes of trace.report are None when using sample_smc—Converting to arviz fails
4 participants