[WIP] Updated GP notebooks #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
|
Awesome, thanks Chris! Going on holidays until July 17, so I'll be away from GH, but I'll be happy to review when I get back 😉 |
Codecov Report
@@ Coverage Diff @@
## master #4005 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 88 88
Lines 14137 14137
=======================================
Hits 12267 12267
Misses 1870 1870 |
AlexAndorra
requested changes
Jul 17, 2020
There was a problem hiding this comment.
Thanks @fonnesbeck, almost all good -- just a nitpick: theano.tensor is imported but unused so it can be dropped.
Also, I can't see the Bokeh plots in the updated version, but I suppose it's due to ReviewNB?
|
Ping @fonnesbeck . |
|
Wasn't quite ready to merge. Will open another PR, |
|
Sorry for jumping the gun.
…On Wed, Jul 29, 2020, 01:32 Chris Fonnesbeck ***@***.***> wrote:
Wasn't quite ready to merge. Will open another PR,
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4005 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGDJZ6PWJVY2SPE4KFTR55NYTANCNFSM4OTL32HQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the GP notebooks. Currently the first Mauna Loa notebook has been fixed; working on a couple of others.