Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HyperGeometric Distribution to pymc3.distributions.discrete #3504 #4108

Closed
wants to merge 8 commits into from
Closed

Add HyperGeometric Distribution to pymc3.distributions.discrete #3504 #4108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e865dc
Add hypergeometric dist. to discrete
Harivallabha Sep 17, 2020
7d12a7b
Add tests for the hypergeometric distribution
Harivallabha Sep 17, 2020
a2bffe7
Clean up linting
Harivallabha Sep 17, 2020
fec3029
Fix linting - 2
Harivallabha Sep 17, 2020
a23960f
Add line in RELEASE-NOTES.md
Harivallabha Sep 17, 2020
bd6e7fb
Run black formatter on discrete.py, test_distributions.py and test_di…
Harivallabha Sep 17, 2020
d797ef7
Remove unnecessary bound condition in logprob of hypergeom
Harivallabha Sep 17, 2020
c708e2f
Change logp of hypergeometric to mirror the scipy implementation
Harivallabha Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

### New features
- `sample_posterior_predictive_w` can now feed on `xarray.Dataset` - e.g. from `InferenceData.posterior`. (see [#4042](https://github.com/pymc-devs/pymc3/pull/4042))
- Support HyperGeometric Distribution through `pymc3.distributions.discrete.HyperGeometric`. (see [#4108](https://github.com/pymc-devs/pymc3/pull/4108))


## PyMC3 3.9.3 (11 August 2020)
Expand Down
2 changes: 2 additions & 0 deletions pymc3/distributions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
from .discrete import ZeroInflatedBinomial
from .discrete import DiscreteUniform
from .discrete import Geometric
from .discrete import HyperGeometric
from .discrete import Categorical
from .discrete import OrderedLogistic

Expand Down Expand Up @@ -136,6 +137,7 @@
'ZeroInflatedBinomial',
'DiscreteUniform',
'Geometric',
'HyperGeometric',
'Categorical',
'OrderedLogistic',
'DensityDist',
Expand Down
Loading