Cast test values to the correct dtype before assignment #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
approved these changes
Nov 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #4221 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 89 89
Lines 14429 14429
=======================================
Hits 12829 12829
Misses 1600 1600
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4219
It's a one-liner fix of a bug that was silently present for years, without attracting any attention.
Only surfaced by recent improvements in Theano-PyMC..