Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less strict test, don't parallelise tests #4265

Merged
merged 4 commits into from
Nov 27, 2020

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Nov 27, 2020

closes #4264

The test pymc3.tests.test_gp.TestMarginalKron passed during the CI process of #4262, but failed when that PR was merged and the CI process was run again (see here).

The test failure shows an absolute difference of 1e-6 - does this indicate a problem, or can the test just be made a bit less strict?

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #4265 (8848620) into master (5ff9bbc) will increase coverage by 13.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4265       +/-   ##
===========================================
+ Coverage   73.90%   87.44%   +13.53%     
===========================================
  Files          88       88               
  Lines       14343    14343               
===========================================
+ Hits        10600    12542     +1942     
+ Misses       3743     1801     -1942     
Impacted Files Coverage Δ
pymc3/model.py 88.88% <0.00%> (+0.22%) ⬆️
pymc3/backends/base.py 86.92% <0.00%> (+0.38%) ⬆️
pymc3/distributions/mixture.py 89.34% <0.00%> (+1.37%) ⬆️
pymc3/tests/helpers.py 60.34% <0.00%> (+1.72%) ⬆️
pymc3/backends/report.py 90.90% <0.00%> (+2.09%) ⬆️
pymc3/step_methods/hmc/base_hmc.py 91.66% <0.00%> (+2.50%) ⬆️
pymc3/tuning/scaling.py 58.18% <0.00%> (+5.45%) ⬆️
pymc3/step_methods/compound.py 95.65% <0.00%> (+8.69%) ⬆️
pymc3/distributions/distribution.py 94.31% <0.00%> (+8.78%) ⬆️
pymc3/distributions/continuous.py 93.27% <0.00%> (+9.15%) ⬆️
... and 26 more

@twiecki
Copy link
Member

twiecki commented Nov 27, 2020

That's fine - thanks!

@MarcoGorelli MarcoGorelli requested a review from twiecki November 27, 2020 12:19
@MarcoGorelli MarcoGorelli changed the title Less strict test Less strict test, don't parallelise tests Nov 27, 2020
@twiecki twiecki merged commit 584e791 into pymc-devs:master Nov 27, 2020
@twiecki
Copy link
Member

twiecki commented Nov 27, 2020

Thanks @MarcoGorelli!

@MarcoGorelli MarcoGorelli deleted the less-strict-test branch November 27, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI process mysteriously fails
2 participants