Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute imports #4292

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Dec 3, 2020

This was discussed but not implemented, and it was pretty easy to write a script to do this so I figured I'd submit a PR


I have no strong opinion on whether relative or absolute imports are better (though PEP8 suggests absolute), but I do think that in a large codebase such as PyMC3's then there is a benefit to consistency

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #4292 (d6d7d39) into master (218dd4a) will decrease coverage by 0.00%.
The diff coverage is 98.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4292      +/-   ##
==========================================
- Coverage   87.57%   87.56%   -0.01%     
==========================================
  Files          88       88              
  Lines       14274    14270       -4     
==========================================
- Hits        12500    12496       -4     
  Misses       1774     1774              
Impacted Files Coverage Δ
pymc3/step_methods/sgmcmc.py 0.00% <0.00%> (ø)
pymc3/backends/__init__.py 100.00% <100.00%> (ø)
pymc3/backends/base.py 86.92% <100.00%> (ø)
pymc3/backends/report.py 90.90% <100.00%> (ø)
pymc3/backends/tracetab.py 100.00% <100.00%> (ø)
pymc3/blocking.py 69.23% <100.00%> (ø)
pymc3/distributions/__init__.py 100.00% <100.00%> (ø)
pymc3/distributions/bart.py 80.80% <100.00%> (ø)
pymc3/distributions/continuous.py 93.31% <100.00%> (ø)
pymc3/distributions/discrete.py 96.78% <100.00%> (ø)
... and 49 more

@MarcoGorelli MarcoGorelli force-pushed the rel-to-abs branch 3 times, most recently from 048ce59 to 01c7d7e Compare December 7, 2020 14:00
@michaelosthege michaelosthege merged commit 0431292 into pymc-devs:master Dec 8, 2020
@MarcoGorelli MarcoGorelli deleted the rel-to-abs branch December 8, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants