Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run putting workflow #4325

Closed
wants to merge 5 commits into from

Conversation

MarcoGorelli
Copy link
Contributor

use inferencedata and arviz-darkgrid

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 11, 2020

View / edit / reply to this conversation on ReviewNB

MarcoGorelli commented on 2020-12-11T13:47:45Z
----------------------------------------------------------------

oops, this is wrong, fixing it now


@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #4325 (4f4076c) into master (2a38198) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4325   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files          88       88           
  Lines       14272    14272           
=======================================
  Hits        12495    12495           
  Misses       1777     1777           

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

michaelosthege commented on 2020-12-12T20:46:08Z
----------------------------------------------------------------

Instead of plotting 50 posterior samples, you could plot a density with

pst = logit_trace.posterior.stack(sample=("chain", "draw"))
pm.gp.util.plot_gp_dist(
    ax=ax, 
    x=t,
    samples=(pst["a"] * t + pst["b"]).values.T
)

@twiecki
Copy link
Member

twiecki commented Dec 14, 2020

/pre-commit-run

@MarcoGorelli
Copy link
Contributor Author

/pre-commit-run

😄 that would require #4330 to be in first

Also, this PR passes the style checks so it wouldn't do anything anyway

@twiecki
Copy link
Member

twiecki commented Dec 14, 2020

/pre-commit-run

@twiecki
Copy link
Member

twiecki commented Dec 14, 2020

Yeah, just checking. It wouldn't comment or anything?

@MarcoGorelli
Copy link
Contributor Author

Not currently, no, it just puts the 'rocket' and 'eyes' emojis (see above). You can see that it was triggered in the 'actions' tab https://github.com/pymc-devs/pymc3/actions

@twiecki
Copy link
Member

twiecki commented Dec 14, 2020

Very cool!

@MarcoGorelli
Copy link
Contributor Author

closing as this will go in pymc-examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants