Code

Dirichlet multinomial (continued)#4373

Code

Merged

AlexAndorra merged 57 commits intopymc-devs:masterpymc-devs/pymc:masterfrom ricardoV94:dirichlet_multinomial_forkricardoV94/pymc:dirichlet_multinomial_forkCopy head branch name to clipboardJan 16, 2021

+390-1

Commits

Commits on Jan 4, 2021

• Add implementation of DM distribution.

  

  bsmith89

  authored and

  ricardoV94

  committed
  b7492d2

  Copy full SHA for b7492d2

• Fix class name mistake.

  

  bsmith89

  authored and

  ricardoV94

  committed
  2106f7c

  Copy full SHA for 2106f7c

• Add DM dist to exported multivariate distributions.

  

  bsmith89

  authored and

  ricardoV94

  committed
  487fc8a

  Copy full SHA for 487fc8a

• Export DirichletMultinomial in pymc3.distributions

  Show description for 24d7ec8
  

  bsmith89

  authored and

  ricardoV94

  committed
  24d7ec8

  Copy full SHA for 24d7ec8

• Attempt at matching Multinomial initialization.

  

  bsmith89

  authored and

  ricardoV94

  committed
  4fbd1d9

  Copy full SHA for 4fbd1d9

• Add some simple tests for DM.

  

  bsmith89

  authored and

  ricardoV94

  committed
  685a428

  Copy full SHA for 685a428

• Correctly deal with 1d n and 2d alpha.

  

  bsmith89

  authored and

  ricardoV94

  committed
  ad8e77e

  Copy full SHA for ad8e77e

• Fix typo in DM random.

  

  bsmith89

  authored and

  ricardoV94

  committed
  8fa717a

  Copy full SHA for 8fa717a

• Fix faulty tests for DM.

  

  bsmith89

  authored and

  ricardoV94

  committed
  4db6b1c

  Copy full SHA for 4db6b1c

• Drop redundant initialization test for DM.

  

  bsmith89

  authored and

  ricardoV94

  committed
  01d359b

  Copy full SHA for 01d359b

• Add test that DM is normalized for n=1 case.

  

  bsmith89

  authored and

  ricardoV94

  committed
  4892355

  Copy full SHA for 4892355

• Add DM test case based on BetaBinomial.

  

  bsmith89

  authored and

  ricardoV94

  committed
  bc5f3bf

  Copy full SHA for bc5f3bf

• Update pymc3/distributions/multivariate.py

  

  ColCarroll

  authored and

  ricardoV94

  committed
  ffa705c

  Copy full SHA for ffa705c

• - Infer shape by default (copied code from Dirichlet Distribution)

  Show description for c801ef1
  ricardoV94

  committed
  c801ef1

  Copy full SHA for c801ef1

• - Use size information in random method

  Show description for c8921ee
  ricardoV94

  committed
  c8921ee

  Copy full SHA for c8921ee

• - Restore merge accidental deletions

  ricardoV94

  committed
  e801568

  Copy full SHA for e801568

• - Underscore missing

  ricardoV94

  committed
  3483ab5

  Copy full SHA for 3483ab5

• - More merge cleaning

  ricardoV94

  committed
  23ba2e4

  Copy full SHA for 23ba2e4

• Bring DirichletMultinomial initialization into alignment with Multinomial.

  

  bsmith89

  authored and

  ricardoV94

  committed
  fe018ec

  Copy full SHA for fe018ec

• Align all DM tests with Multinomial.

  

  bsmith89

  authored and

  ricardoV94

  committed
  25fd41a

  Copy full SHA for 25fd41a

• Align DirichletMultinomial random implementation with Multinomial.

  

  bsmith89

  authored and

  ricardoV94

  committed
  28b0a62

  Copy full SHA for 28b0a62

• Match DM random method to Multinomial implementation.

  

  bsmith89

  authored and

  ricardoV94

  committed
  d363f96

  Copy full SHA for d363f96

• Change alpha -> a

  Show description for 9b6828c
  ricardoV94

  committed
  9b6828c

  Copy full SHA for 9b6828c

• Run pre-commit

  ricardoV94

  committed
  d438dfc

  Copy full SHA for d438dfc

• Keep standard order of methods random and logp

  ricardoV94

  committed
  dde5c45

  Copy full SHA for dde5c45

• Update docstrings for valid input types.

  Show description for 49b432d
  ricardoV94

  committed
  49b432d

  Copy full SHA for 49b432d

• Add new test to ensure DM matches BetaBinom

  ricardoV94

  committed
  83fbda6

  Copy full SHA for 83fbda6

• Change DM alpha -> a in docstrings.

  bsmith89

  committed
  9748a9d

  Copy full SHA for 9748a9d

• Test two additional parameterization shapes in test_dirichlet_multinomial_random.

  bsmith89

  committed
  7b20680

  Copy full SHA for 7b20680

• Revert debugging comments.

  bsmith89

  committed
  66c83b0

  Copy full SHA for 66c83b0

• Revert unrelated changes.

  bsmith89

  committed
  672ef56

  Copy full SHA for 672ef56

• Fix minor Black inconsistency.

  bsmith89

  committed
  2d5d20e

  Copy full SHA for 2d5d20e

Commits on Jan 5, 2021

• Drop no-longer-functional reshaping code.

  bsmith89

  committed
  922515b

  Copy full SHA for 922515b

• Assert shape of random samples is as expected.

  bsmith89

  committed
  aa89d0a

  Copy full SHA for aa89d0a

• Explicitly test random sample shapes, including batch dimensions.

  bsmith89

  committed
  2343004

  Copy full SHA for 2343004

• Sort imports.

  bsmith89

  committed
  a08bc51

  Copy full SHA for a08bc51

Commits on Jan 6, 2021

• Simplify _random

  Show description for 22beead
  ricardoV94

  committed
  22beead

  Copy full SHA for 22beead

• Reorder tests more logically

  ricardoV94

  committed
  7bad831

  Copy full SHA for 7bad831

• Refactor tests

  Show description for 9bbddba
  ricardoV94

  committed
  9bbddba

  Copy full SHA for 9bbddba

• Require shape argument

  Show description for 086459f
  ricardoV94

  committed
  086459f

  Copy full SHA for 086459f

• Remove unused import to_tuple

  ricardoV94

  committed
  f8499d3

  Copy full SHA for f8499d3

• Simplify logic to handle list as input for a

  ricardoV94

  committed
  1cd2a9f

  Copy full SHA for 1cd2a9f

Commits on Jan 10, 2021

• Raise ShapeError in random()

  ricardoV94

  committed
  ef00fe1

  Copy full SHA for ef00fe1

• Finish batch and repr unittests

  ricardoV94

  committed
  f2ac8e9

  Copy full SHA for f2ac8e9

• Add note about mode

  ricardoV94

  committed
  f5dcdc3

  Copy full SHA for f5dcdc3

• Tiny rewording

  ricardoV94

  committed
  c4e017a

  Copy full SHA for c4e017a

Commits on Jan 12, 2021

• Change mode to _defaultval

  ricardoV94

  committed
  d46dd50

  Copy full SHA for d46dd50

• Revert comment for Multinomial mode

  ricardoV94

  committed
  3ab518d

  Copy full SHA for 3ab518d

• Update shape check logic

  ricardoV94

  committed
  cdd6d27

  Copy full SHA for cdd6d27

• Add DM to release notes.

  bsmith89

  committed
  24447a4

  Copy full SHA for 24447a4

• Merge branch 'master' into dirichlet_multinomial_fork

  bsmith89

  authored
  c5e9b67

  Copy full SHA for c5e9b67

Commits on Jan 14, 2021

• Minor docstring revisions as suggested by @AlexAndorra.

  bsmith89

  committed
  0bd6c3d

  Copy full SHA for 0bd6c3d

• Revise the revision.

  bsmith89

  committed
  f919456

  Copy full SHA for f919456

• Add comment clarifying bounds checking in logp()

  bsmith89

  committed
  c082f00

  Copy full SHA for c082f00

Commits on Jan 15, 2021

• Address review suggestions

  ricardoV94

  committed
  ea0ae59

  Copy full SHA for ea0ae59

• Update matches_beta_binomial to take into consideration float precision

  ricardoV94

  committed
  b451967

  Copy full SHA for b451967

Commits on Jan 16, 2021

• Add DM to multivariate distributions docs.

  bsmith89

  committed
  128d5cf

  Copy full SHA for 128d5cf