-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - Update PyMC3 Installation focus via Conda Forge #4401
Docs - Update PyMC3 Installation focus via Conda Forge #4401
Conversation
@twiecki I still left the mention of Let me know if you want me to completely remove that mention. |
Codecov Report
@@ Coverage Diff @@
## master #4401 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 88 88
Lines 14563 14563
=======================================
Hits 12841 12841
Misses 1722 1722 |
✏️ Update README.rst Add note about pip installation Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com> Update README.rst Add context to pip installation and dependencies Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com> Apply suggestions from code review Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com> ✏️ README installation update
9e82068
to
e098482
Compare
Thanks for the suggestions! Updated the PR w/squash'd commits |
README.rst
Outdated
However, if a recent version of Theano has already been installed on | ||
your system, you can install PyMC3 directly from GitHub. | ||
.. note:: | ||
If you already have `Theano-PyMC <https://github.com/pymc-devs/Theano-PyMC>`__ installed, then re-install the module, as such |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should say that it now requires Theano-PyMC instead of just the old Theano, and that if the old Theano is installed, they just remove that and install Theano-PyMC via conda-forge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twiecki Sounds great, I think I made the appropriate changes. Moreover, I changed the sub-bulletin title of the Installation
section to be Theano-PyMC Installation
.
Let me know what you think.
Thanks @CloudChaoszero ! |
Description
Closes #4398
Example
This preview was on my local machine