Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Theano to Aesara #4471

Merged

Conversation

brandonwillard
Copy link
Contributor

@brandonwillard brandonwillard commented Feb 12, 2021

This PR renames Theano to Aesara, changes the Theano-PyMC dependency to Aesara, etc. Included in the rename is a rename of the theanof module to aesaraf.

This most likely won't pass until the conda-forge rename (conda-forge/staged-recipes#13825) and Arviz changes (arviz-devs/arviz#1553) next release for Arviz is cut.

@brandonwillard brandonwillard self-assigned this Feb 12, 2021
@brandonwillard brandonwillard force-pushed the rename-theano-to-aesara branch 2 times, most recently from f7b6b00 to dbc7447 Compare February 13, 2021 18:22
@brandonwillard brandonwillard force-pushed the rename-theano-to-aesara branch 3 times, most recently from e0a8189 to a9db173 Compare February 26, 2021 03:13
@brandonwillard brandonwillard marked this pull request as ready for review February 26, 2021 03:57
@brandonwillard
Copy link
Contributor Author

The Windows tests should pass once pymc-devs/pytensor#307 goes through.

README.rst Outdated Show resolved Hide resolved
docs/source/Advanced_usage_of_Theano_in_PyMC3.rst Outdated Show resolved Hide resolved
docs/source/PyMC3_and_Theano.rst Outdated Show resolved Hide resolved
docs/source/about.rst Outdated Show resolved Hide resolved
docs/source/about.rst Outdated Show resolved Hide resolved
pymc3/model_graph.py Show resolved Hide resolved
@brandonwillard
Copy link
Contributor Author

brandonwillard commented Feb 26, 2021

The only test failure is suspiciously close to the expected relative error, and I can't reproduce it locally. I also run Ubuntu and a very similar Conda environment, so I'm assuming this error is RNG-based.

Setting the seed at the start of that one test resolves the error.

@brandonwillard brandonwillard force-pushed the rename-theano-to-aesara branch 2 times, most recently from 9b2b566 to 738b994 Compare February 26, 2021 20:16
@brandonwillard brandonwillard force-pushed the rename-theano-to-aesara branch from 738b994 to b3a2d2e Compare February 26, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants