-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exponential and gamma logp / random link #4576
Fix exponential and gamma logp / random link #4576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need to create that new RandomVariable
or add a new optional parameterization at this time.
What do you suggest instead? Shall we leave the distributions not matching parameters on the logp and random sides? For the exponential even if we don't provide it as an option, we still need to use The gamma right now requires changing the aesara op one way or another as explained in the comment above. |
We only need to keep the |
7c2edbe
to
6a86c34
Compare
I removed the explicit new parametrization of the |
6a86c34
to
bda3558
Compare
93a096d
to
c9fa127
Compare
bda3558
to
8262595
Compare
I rebased this branch onto the update |
8262595
to
862693f
Compare
Thanks! |
cfe6599
to
d388c83
Compare
3c24e0e
to
23cffdc
Compare
I changed the exponential |
Unrelated to this PR this test failed: |
After merging #4548, the
Exponential
andGamma
distributions still have a mismatch between the logp and random parametrizations.I still think it is more straightforward to keep relying on the tests in
test_distributions_random.py
while we refactor the distributions into V4 as it easily identifies this type of issues. There is already an open issue to refactor these tests #4554, so it will not be forgotten.For the discussion into the Exponential and Gamma changes see my previous comments:
There seems to be a problem with the Categorical (
test_distributions_random::TestScalarParameterSamples::test_categorical_random
), but perhaps it was addressed by pymc-devs/pytensor#351?