Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flexible shape/dims/size API #4625

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Implement flexible shape/dims/size API #4625

merged 3 commits into from
Apr 20, 2021

Commits on Apr 18, 2021

  1. Allow unnamed (None) dims and undefined (None) coord values 

    Also refactor into properties to add docstrings and type annotations.
And no longer allow InferenceData conversion without a Model on stack.

Co-authored-by: Oriol Abril Pla <oriol.abril.pla@gmail.com>
    @michaelosthege @OriolAbril
    michaelosthege and OriolAbril committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    fd3f730 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Allow parametrization through either shape, dims or size 

    Always treats `size` as being in addition to dimensions implied by RV parameters.

All resizing beyond parameter-implied dimensionality is done from:
- `shape` or `size` in `Distribution.dist()`
- `dims` or `observed` in `Distribution.__new__`
and only in those two places.

Closes pymc-devs#4552.
    @michaelosthege
    michaelosthege committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3ce51ab View commit details
    Browse the repository at this point in the history

  2. Automatically add SpecifyShape Op when full-length shape is given

    @michaelosthege
    michaelosthege committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5007d97 View commit details
    Browse the repository at this point in the history